Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate enzyme with RTL #615

Merged
merged 2 commits into from
Dec 26, 2023
Merged

feat: migrate enzyme with RTL #615

merged 2 commits into from
Dec 26, 2023
+11,493 −7,160

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

Description:

This PR deprecates enzyme and shift all test cases to RTL.

Merge checklist:

  • Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
  • Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
  • Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

  • After the build finishes for the merged commit, verify the new release has been pushed to NPM.

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (683f57d) 83.22% compared to head (fc8e587) 83.50%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
+ Coverage   83.22%   83.50%   +0.27%     
==========================================
  Files          40       40              
  Lines        1073     1073              
  Branches      197      197              
==========================================
+ Hits          893      896       +3     
+ Misses        168      165       -3     
  Partials       12       12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abdullahwaheed abdullahwaheed merged commit cdbd00d into master Dec 26, 2023
7 checks passed
@abdullahwaheed abdullahwaheed deleted the Ali-Abbas/migrate-enzyme-to-rtl branch December 26, 2023 08:09
@brian-smith-tcril brian-smith-tcril mentioned this pull request Feb 3, 2024
Merged
@brian-smith-tcril brian-smith-tcril mentioned this pull request Feb 16, 2024
Merged
@arbrandes arbrandes mentioned this pull request Mar 6, 2024
Open
bra-i-am pushed a commit to eduNEXT/frontend-platform that referenced this pull request May 14, 2024
@Syed-Ali-Abbas-Zaidi @bra-i-am
feat: migrate enzyme with RTL (openedx#615)
d7e83ae
bra-i-am pushed a commit to eduNEXT/frontend-platform that referenced this pull request Aug 9, 2024
@Syed-Ali-Abbas-Zaidi @bra-i-am
feat: migrate enzyme with RTL (openedx#615)
53215b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdullahwaheed abdullahwaheed abdullahwaheed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syed-Ali-Abbas-Zaidi @abdullahwaheed